zzzming commented on code in PR #20498:
URL: https://github.com/apache/pulsar/pull/20498#discussion_r1221512684
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java:
##########
@@ -78,6 +90,7 @@ public void afterBulk(long executionId,
List<BulkProcessor.BulkOperationRequest>
record.fail();
checkForIrrecoverableError(record, result);
} else {
+ incrementCounter(METRICS_TOTAL_SUCCESS, index);
Review Comment:
Increment counter of failure and skip cases are in the
checkIrrecoverableError() method because there are different cases to cover
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
