asafm commented on code in PR #20498:
URL: https://github.com/apache/pulsar/pull/20498#discussion_r1221664570
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java:
##########
@@ -96,6 +110,12 @@ public void afterBulk(long executionId,
List<BulkProcessor.BulkOperationRequest>
this.client = retry(() -> RestClientFactory.createClient(config,
bulkListener), -1, "client creation");
}
+ public void incrementCounter(String counter, double value) {
+ if (sinkContext != null && counter != null) {
Review Comment:
Can you please explain what is the relation of `sinkContext != null` to
`KinesisSink` in this method/line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
