lifepuzzlefun commented on PR #20512: URL: https://github.com/apache/pulsar/pull/20512#issuecomment-1585433978
@heesung-sn Thanks for review. I agree that the delete threshold is just a workaround to avoid the active bundle data to delete. After check the origin pr https://github.com/apache/pulsar/pull/13974 The intention is that when bundle split 1. Remove the bundle-data from the metadataStore. 2. the `loadData` in `ModularLoadManagerImpl` should be update to remove the in-memory bundle-data. So for problem 1： when bundle split is triggered by the leader or the LoadManager, the data is already deleted. (`ModularLoadManagerImpl.checkNamespaceBundleSplit`) when bundle split is triggered by the admin api. we need to add the logic to delete the bundle data from the metadataStore. For problem 2: Maybe a schedule task to check every namespace active bundles and update the `loadData` can also do the clean up, and the origin logic in `updateBundleData` will be removed. WDYT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
