lifepuzzlefun commented on PR #20512: URL: https://github.com/apache/pulsar/pull/20512#issuecomment-1588447537
> `but the current logic will cause amost all bundle-datas in the cluster to be deleted, each time the updateBundleData method triggered.` > > Regarding this problem, can we confirm if this is an indeed issue? It sounds like the bundleData was just removed because the load report is delayed. Aha, this patch seems evolve by me a lot, let me explain the missing detail. For the most important thing. The bundle-data is need to be preserve. current code will cause most of the bundle-data lost long-term history traffic, which `loadShedTask` and `bundleSplitTask` relay on this. If the bundle-data is delete wrongly, those task only have default bundle-data, which is not the cluster real traffic. How this patch idea changes. 1. current master code in `updateBundleData` did not iterate all the brokerData to get right activeBundleData, which cause the bundle-data to be delete. 2. after change the `updateBundleData` to only check activeBundleData after iterator all the brokerData. I found that the delayed load report will also cause the real active bundle load data lost. 3. change to current version, which will scan the namespace, get the policy, and check the real exist bundle in the cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
