mattisonchao commented on code in PR #20568:
URL: https://github.com/apache/pulsar/pull/20568#discussion_r1230389409
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##########
@@ -361,6 +361,13 @@ public Future<Void> sendMessages(final List<? extends
Entry> entries, EntryBatch
msgOutCounter.add(totalMessages);
bytesOutCounter.add(totalBytes);
chunkedMessageRate.recordMultipleEvents(totalChunkedMessages,
0);
+ } else {
+ log.warn("[{}-{}] Sent messages to client fail by IO
exception[{}], these messages(messages count:"
Review Comment:
Have you considered the connection problems that will print tons of logs
here? :)
IMO, the message trace logs should be considered carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
