heesung-sn commented on code in PR #20620:
URL: https://github.com/apache/pulsar/pull/20620#discussion_r1237369059
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -603,6 +592,16 @@ private void updateBundleData() {
LoadManagerShared.fillNamespaceToBundlesMap(preallocatedBundleData.keySet(),
namespaceToBundleRange);
}
}
+
Review Comment:
Sorry, maybe I missed some logic here.
But, In this func, I don't see `bundleData` and `activeBundles` are updated
between these lines.
https://github.com/apache/pulsar/pull/20620/files#diff-642d3e26ddad51db8fb736b0f5519f4c929814a4f69d85e16829d19b885be0ebR562-R594
.
So, I am curious to know how this reordering can be effective.
> To get all cluster wide bundle data, we need iterate all brokerData to
collect this.
> Current we only iterate the first brokerData and check active bundles. so
the all the bundleData which is not owned by the first broker will be cleaned
at the first broker check.
Can you provide the code lines which iterate all brokerData and fill
`activeBundles` and `bundleData`, other than here?
https://github.com/apache/pulsar/pull/20620/files#diff-642d3e26ddad51db8fb736b0f5519f4c929814a4f69d85e16829d19b885be0ebR549-R558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
