lifepuzzlefun commented on PR #20620:
URL: https://github.com/apache/pulsar/pull/20620#issuecomment-1601979815
> Oh. I mis-read the change. I got it now. This removal has been moved out
of the loop, `for (Map.Entry<String, BrokerData> brokerEntry :
loadData.getBrokerData().entrySet())`
>
> ```
> //Remove not active bundle from loadData
> for (String bundle : bundleData.keySet()) {
> if (!activeBundles.contains(bundle)){
> bundleData.remove(bundle);
> if (pulsar.getLeaderElectionService().isLeader()){
> deleteBundleDataFromMetadataStore(bundle);
> }
> }
> }
> ```
>
> LGTM.
Thanks for review this fix, I'll try to explain myself more clearly next
time :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
