michaeljmarshall commented on code in PR #20566:
URL: https://github.com/apache/pulsar/pull/20566#discussion_r1245625640
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3304,10 +3305,19 @@ private CompletableFuture<Boolean>
isAllowAutoTopicCreationAsync(final TopicName
topicName.getNamespaceObject());
return CompletableFuture.completedFuture(false);
}
- //System topic can always be created automatically
+
+ // ServiceUnitStateChannelImpl.TOPIC expects to be a
non-partitioned-topic now.
+ // We don't allow the auto-creation here.
+ // ServiceUnitStateChannelImpl.start() is responsible to create the
topic.
+ if (ServiceUnitStateChannelImpl.TOPIC.equals(topicName.toString())) {
Review Comment:
A third option is to only auto create topics as non-partitioned topics. Any
component that needs to create a system topic as a partitioned topic could do
so on start up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
