Technoboy- commented on code in PR #20804:
URL: https://github.com/apache/pulsar/pull/20804#discussion_r1263325619
##########
pulsar-common/src/test/java/org/apache/pulsar/common/policies/data/OffloadPoliciesTest.java:
##########
@@ -432,4 +433,16 @@ private byte[] loadClassData(String name) throws
IOException {
}
}
+ @Test
+ public void testCreateOffloadPoliciesWithExtraConfiguration() {
+ Properties properties = new Properties();
+ properties.put("managedLedgerOffloadExtraConfigKey1", "value1");
+ properties.put("managedLedgerOffloadExtraConfigKey2", "value2");
+ OffloadPoliciesImpl policies = OffloadPoliciesImpl.create(properties);
Review Comment:
```
Properties properties = new Properties();
Properties extraProps = new Properties();
extraProps.put("configKey1", "value1");
extraProps.put("configKey2", "value2");
properties.put("managedLedgerOffloadExtraConfig", extraProps);
OffloadPoliciesImpl policies = OffloadPoliciesImpl.create(properties);
```
Seems better then `prefix` keys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
