zymap commented on code in PR #20804:
URL: https://github.com/apache/pulsar/pull/20804#discussion_r1263334175
##########
pulsar-common/src/test/java/org/apache/pulsar/common/policies/data/OffloadPoliciesTest.java:
##########
@@ -432,4 +433,16 @@ private byte[] loadClassData(String name) throws
IOException {
}
}
+ @Test
+ public void testCreateOffloadPoliciesWithExtraConfiguration() {
+ Properties properties = new Properties();
+ properties.put("managedLedgerOffloadExtraConfigKey1", "value1");
+ properties.put("managedLedgerOffloadExtraConfigKey2", "value2");
+ OffloadPoliciesImpl policies = OffloadPoliciesImpl.create(properties);
Review Comment:
The properties come from the ServiceConfiguration, so we need a prefix to
avoid bringing too many unused properties into the offloader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
