RobertIndie commented on PR #300: URL: https://github.com/apache/pulsar-client-cpp/pull/300#issuecomment-1637652415
> Oh it's right. But receiveAtLeast is also wrong because this method cannot receive over N messages. I don't seem to get it. `receiveAtLeast` means that we just need to assert that we at least receive N messages. And we don't care messages that over N. > The proper implementation of receiveAtMost might be: It seems the only difference is that we move the assertion out of this method. I think it's more intuitive to think of `receive AtMost` as an assertion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
