BewareMyPower commented on PR #300: URL: https://github.com/apache/pulsar-client-cpp/pull/300#issuecomment-1641215759
If this method never return messages whose count is other than N, both `receiveAtMost` and `receiveLeast` are not good names. > It seems the only difference is that we move the assertion out of this method. Yes, it now can return messages whose count is less or equal to N. Users can check the size to determine whether there are al least N messages. For example, if you sent 5 messages and `receiveAtMost(5)` returns only `[0, 1, 2]`, the test should fail. You can either check the returned result or the `messageIdList_` field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
