nodece commented on code in PR #20268:
URL: https://github.com/apache/pulsar/pull/20268#discussion_r1270178313
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java:
##########
@@ -162,11 +162,8 @@ protected class LocalSinkRunner extends CreateSink {
@Parameter(names = "--tls-allow-insecure", description = "Allow
insecure tls connection")
protected boolean tlsAllowInsecureConnection;
- @Parameter(names = "--hostname_verification_enabled",
- description = "Enable hostname verification", hidden = true)
- protected Boolean deprecatedTlsHostNameVerificationEnabled;
- @Parameter(names = "--hostname-verification-enabled", description =
"Enable hostname verification")
- protected boolean tlsHostNameVerificationEnabled;
+ @Parameter(names = "--hostname-verification-enabled", description =
"Enable hostname verification", arity = 1)
+ protected boolean tlsHostNameVerificationEnabled = true;
Review Comment:
It seems we should keep the `--hostname_verification_enabled` flag for
backward compatibility.
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java:
##########
@@ -162,11 +162,8 @@ protected class LocalSinkRunner extends CreateSink {
@Parameter(names = "--tls-allow-insecure", description = "Allow
insecure tls connection")
protected boolean tlsAllowInsecureConnection;
- @Parameter(names = "--hostname_verification_enabled",
Review Comment:
It seems we should keep the `--hostname_verification_enabled` flag for
backward compatibility.
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java:
##########
@@ -780,12 +780,9 @@ class LocalRunner extends FunctionDetailsCommand {
@Parameter(names = "--tls-allow-insecure", description = "Allow
insecure tls connection #Java, Python")
protected boolean tlsAllowInsecureConnection;
// for backwards compatibility purposes
- @Parameter(names = "--hostname_verification_enabled",
- description = "Enable hostname verification", hidden = true)
- protected Boolean deprecatedTlsHostNameVerificationEnabled = null;
@Parameter(names = "--hostname-verification-enabled", description =
"Enable hostname verification"
- + " #Java, Python")
- protected boolean tlsHostNameVerificationEnabled;
+ + " #Java, Python", arity = 1)
+ protected boolean tlsHostNameVerificationEnabled = true;
Review Comment:
It seems we should keep the `--hostname_verification_enabled` flag for
backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
