nodece commented on code in PR #20268:
URL: https://github.com/apache/pulsar/pull/20268#discussion_r1271274396
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java:
##########
@@ -780,12 +780,9 @@ class LocalRunner extends FunctionDetailsCommand {
@Parameter(names = "--tls-allow-insecure", description = "Allow
insecure tls connection #Java, Python")
protected boolean tlsAllowInsecureConnection;
// for backwards compatibility purposes
- @Parameter(names = "--hostname_verification_enabled",
Review Comment:
Thank you for your explanation! When the `--hostname-verification-enabled`
with `arity = 1`, we must set a value after this flag. This change is
incompatible with the old usage.
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]