poorbarcode commented on code in PR #20855:
URL: https://github.com/apache/pulsar/pull/20855#discussion_r1271650394


##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/CompletableFutures.java:
##########
@@ -0,0 +1,41 @@
+package org.apache.pulsar.common.util;

Review Comment:
   Please add the Licensed to the (ASF)



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3340,11 +3339,13 @@ private AutoTopicCreationOverride 
getAutoTopicCreationOverride(final TopicName t
         return null;
     }
 
+    @Deprecated

Review Comment:
   Deprecate method should be explained, and new method suggested
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to