codelipenghui commented on code in PR #20855:
URL: https://github.com/apache/pulsar/pull/20855#discussion_r1273143964
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -1166,6 +1178,7 @@ public void updateResourceGroupLimiter(Optional<Policies>
optPolicies) {
}
}
+
Review Comment:
Remove the empty line.
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/CompletableFutures.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.common.util;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionStage;
+import java.util.function.Supplier;
+import javax.annotation.Nonnull;
+import lombok.experimental.UtilityClass;
+
+@UtilityClass
+public final class CompletableFutures {
+ public static <T> @Nonnull CompletionStage<T> apply(@Nonnull Supplier<T>
fn) {
Review Comment:
Can we remove it first since no one uses this method now?
And we already have `FutureUtil.java`, can we use the existing one?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -1128,6 +1131,12 @@ public PublishRateLimiter getBrokerPublishRateLimiter() {
return brokerService.getBrokerPublishRateLimiter();
}
+ /**
+ * @deprecated Avoid using the deprecated method
+ * #{@link
org.apache.pulsar.broker.resources.NamespaceResources#getPoliciesIfCached(NamespaceName)}
and we can use
+ * #{@link AbstractTopic#updateResourceGroupLimiter(Policies)} to instead
of it.
+ */
+ @Deprecated
Review Comment:
Why not just fix this method?
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/CompletableFutures.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.common.util;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionStage;
+import java.util.function.Supplier;
+import javax.annotation.Nonnull;
+import lombok.experimental.UtilityClass;
+
+@UtilityClass
+public final class CompletableFutures {
+ public static <T> @Nonnull CompletionStage<T> apply(@Nonnull Supplier<T>
fn) {
+ try {
+ final CompletableFuture<T> future = new CompletableFuture<>();
+ if (fn == null) {
+ future.completeExceptionally(new
NullPointerException("Parameter can not be null."));
+ return future;
+ }
+ future.complete(fn.get());
+ return future;
+ } catch (Throwable ex) {
+ final CompletableFuture<T> future = new CompletableFuture<>();
+ future.completeExceptionally(ex);
+ return future;
+ }
+ }
+
+ public static <T> @Nonnull CompletionStage<T> compose(@Nonnull
Supplier<CompletionStage<T>> fn) {
+ try {
+ if (fn == null) {
Review Comment:
fn cannot be null.
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/CompletableFutures.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.common.util;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionStage;
+import java.util.function.Supplier;
+import javax.annotation.Nonnull;
+import lombok.experimental.UtilityClass;
+
+@UtilityClass
+public final class CompletableFutures {
+ public static <T> @Nonnull CompletionStage<T> apply(@Nonnull Supplier<T>
fn) {
+ try {
+ final CompletableFuture<T> future = new CompletableFuture<>();
+ if (fn == null) {
Review Comment:
fn cannot be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
