315157973 commented on code in PR #20766:
URL: https://github.com/apache/pulsar/pull/20766#discussion_r1272956749
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -487,6 +487,13 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
)
private long brokerShutdownTimeoutMs = 60000;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "The max bundle unload concurrency limit when broker
shutdown. Set to 0 means no limit."
+ )
+ private int brokerShutdownMaxBundleUnloadPerMinute = 0;
Review Comment:
Why is the unit in minutes
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -487,6 +487,13 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
)
private long brokerShutdownTimeoutMs = 60000;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
Review Comment:
dynamic = true
Is it necessary? And I don't see a way to modify it dynamically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
