lifepuzzlefun commented on code in PR #20766:
URL: https://github.com/apache/pulsar/pull/20766#discussion_r1278545617
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -941,9 +942,11 @@ public void unloadNamespaceBundlesGracefully() {
unloadNamespaceBundlesGracefully(0, true);
}
- public void unloadNamespaceBundlesGracefully(int maxConcurrentUnload,
boolean closeWithoutWaitingClientDisconnect) {
+ public void unloadNamespaceBundlesGracefully(
Review Comment:
I think this changes the behaviour. We would better take limit rate and
timeUnit as parameters and create another method.
Current adminAPI
`org.apache.pulsar.broker.admin.impl.BrokerBase.shutDownBrokerGracefully` will
call this method as a persecond limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
