entvex commented on code in PR #162:
URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288278719
##########
src/DotPulsar/Internal/SubProducer.cs:
##########
@@ -201,7 +205,15 @@ private void ProcessReceipt(CommandSendReceipt sendReceipt)
_sendQueue.Dequeue();
var srMsgId = sendReceipt.MessageId;
- var messageId = _partition == -1 ? srMsgId.ToMessageId() : new
MessageId(srMsgId.LedgerId, srMsgId.EntryId, _partition, srMsgId.BatchIndex);
+ MessageId messageId;
+ if (_partition == -1)
Review Comment:
Right! Changed to just one line
```suggestion
var messageId= new MessageId(srMsgId.LedgerId, srMsgId.EntryId, _partition,
srMsgId.BatchIndex, Topic);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
