entvex commented on code in PR #162:
URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1293209334
##########
tests/DotPulsar.Tests/ConsumerTests.cs:
##########
@@ -70,6 +69,115 @@ public async Task
Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM
consumed.Should().BeEquivalentTo(produced);
}
+ [Fact]
+ public async Task
GetLastMessageId_GivenPartitionedTopic_ShouldThrowException()
+ {
+ //Arrange
+ var testRunId = Guid.NewGuid().ToString("N");
+ const int partitions = 3;
+ var topicName =
$"persistent://public/default/consumer-tests-{testRunId}";
+
+ _fixture.CreatePartitionedTopic(topicName, partitions);
+
+ await using var client = PulsarClient.Builder()
+ .ServiceUrl(_fixture.ServiceUrl)
+ .Authentication(AuthenticationFactory.Token(ct =>
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
+ .Build();
+
+ var consumer = client.NewConsumer(Schema.ByteArray)
+ .ConsumerName($"consumer-{testRunId}")
+ .InitialPosition(SubscriptionInitialPosition.Earliest)
+ .SubscriptionName($"subscription-{testRunId}")
+ .Topic(topicName)
+ .Create();
+
+ //Act
+ var exception = await Record.ExceptionAsync(() =>
consumer.GetLastMessageId().AsTask());
+
+ //Assert
+ exception.Should().BeOfType<NotSupportedException>();
+ }
+
+ [Fact]
+ public async Task
Receive_GivenPartitionedTopicWithMessages_ShouldReceiveAll()
+ {
+ //Arrange
+ var testRunId = Guid.NewGuid().ToString("N");
+ const int partitions = 3;
+ const int numberOfMessages = 10000;
+ var topicName = $"consumer-with-3-partitions-test";
+
+
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}",
partitions);
+
+ await using var client = PulsarClient.Builder()
+ .ServiceUrl(_fixture.ServiceUrl)
+ .Authentication(AuthenticationFactory.Token(ct =>
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
+ .Build();
+
+ await using var consumer = client.NewConsumer(Schema.ByteArray)
+ .ConsumerName($"consumer-{testRunId}")
+ .InitialPosition(SubscriptionInitialPosition.Earliest)
+ .SubscriptionName($"subscription-{testRunId}")
+ .Topic(topicName)
+ .Create();
+
+ await using var producer = client.NewProducer(Schema.ByteArray)
+ .ProducerName($"producer-{testRunId}")
+ .Topic(topicName)
+ .Create();
+
+ var cts = new CancellationTokenSource(TimeSpan.FromSeconds(60));
+
+ //Act
+ var produced = await ProduceMessages(producer, numberOfMessages,
cts.Token);
+ var consumed = await ConsumeMessages(consumer, numberOfMessages,
cts.Token);
+
+ //Assert
+ consumed.Should().BeEquivalentTo(produced);
+ }
+
+ [Fact]
+ public async Task
GetLastMessageIds_GivenMessageIdsFrom3Partitions_ShouldHave3Partitions()
+ {
+ //Arrange
+ var testRunId = Guid.NewGuid().ToString("N");
+ const int partitions = 3;
+ const int numberOfMessages = 6;
+ var topicName = $"consumer_get_last_message_ids_should_have_3_topics";
+
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}",
partitions);
+
+ await using var client = PulsarClient.Builder()
+ .ServiceUrl(_fixture.ServiceUrl)
+ .Authentication(AuthenticationFactory.Token(ct =>
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
+ .Build();
+
+ await using var producer = client.NewProducer(Schema.String)
+ .Topic(topicName)
+ .Create();
+
+ await using var consumer = client.NewConsumer(Schema.ByteArray)
+ .ConsumerName($"consumer-{testRunId}")
+ .InitialPosition(SubscriptionInitialPosition.Earliest)
+ .SubscriptionName($"subscription-{testRunId}")
+ .Topic(topicName)
+ .Create();
+
+ List<MessageId> expected = new List<MessageId>();
Review Comment:
Done
##########
tests/DotPulsar.Tests/ReaderTests.cs:
##########
@@ -0,0 +1,253 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace DotPulsar.Tests;
+
+using DotPulsar.Abstractions;
+using DotPulsar.Extensions;
+using FluentAssertions;
+using System;
+using System.Collections.Generic;
+using System.Threading;
+using System.Threading.Tasks;
+using Xunit;
+using Xunit.Abstractions;
+
+[Collection("Integration"), Trait("Category", "Integration")]
+public class ReaderTests
+{
+ private readonly IntegrationFixture _fixture;
+ private readonly ITestOutputHelper _testOutputHelper;
+
+ public ReaderTests(IntegrationFixture fixture, ITestOutputHelper
testOutputHelper)
+ {
+ _fixture = fixture;
+ _testOutputHelper = testOutputHelper;
+ }
+
+ [Fact]
+ public async Task Receive_GivenTopicWithMessages_ShouldReceiveAll()
+ {
+ //Arrange
+ await using var client = CreateClient();
+ const int numberOfMessages = 10;
+ var topicName = $"simple-produce-consume{Guid.NewGuid():N}";
+
+ await using var producer = client.NewProducer(Schema.String)
+ .Topic(topicName)
+ .Create();
+
+ await using var reader = client.NewReader(Schema.String)
+ .StartMessageId(MessageId.Earliest)
+ .Topic(topicName)
+ .Create();
+
+ var expected = new List<MessageId>();
+ for (var i = 0; i < numberOfMessages; i++)
+ {
+ var messageId = await producer.Send("test-message");
+ expected.Add(messageId);
+ }
+
+ //Act
+ var actual = new List<MessageId>();
+ for (var i = 0; i < numberOfMessages; i++)
+ {
+ var messageId = await reader.Receive();
+ actual.Add(messageId.MessageId);
+ }
+
+ //Assert
+ actual.Should().BeEquivalentTo(expected);
+ }
+
+ [Fact]
+ public async Task
Receive_GivenPartitionedTopicWithMessages_ShouldReceiveAll()
+ {
+ //Arrange
+ const int partitions = 3;
+ const int numberOfMessages = 50;
+ var topicName = $"reader-with-3-partitions-test";
+
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}",
partitions);
+
+ await using var client = CreateClient();
+
+ await using var producer = client.NewProducer(Schema.String)
+ .Topic(topicName)
+ .Create();
+
+ await using var reader = client.NewReader(Schema.String)
+ .StartMessageId(MessageId.Earliest)
+ .Topic(topicName)
+ .Create();
+
+ var expected = new List<MessageId>();
+ for (var i = 0; i < numberOfMessages; i++)
+ {
+ var messageId = await producer.Send("test-message");
+ expected.Add(messageId);
+ }
+
+ //Act
+ var actual = new List<MessageId>();
+ for (var i = 0; i < numberOfMessages; i++)
+ {
+ var messageId = await reader.Receive();
+ actual.Add(messageId.MessageId);
+ }
+
+ //Assert
+ actual.Should().BeEquivalentTo(expected);
+ }
+
+ [Fact]
+ public async Task
Receive_GivenPartitionedTopicWithMessages_ShouldReturnMessagesFromDifferentPartitions()
+ {
+ //Arrange
+ const int partitions = 3;
+ const int numberOfMessages = 20;
+ var topicName = $"reader-should-read-from-different-partitions-test";
+
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}",
partitions);
+
+ await using var client = CreateClient();
+ const string content = "test-message";
+
+ await using var producer = client.NewProducer(Schema.String)
+ .Topic(topicName)
+ .Create();
+
+ await using var reader = client.NewReader(Schema.String)
+ .StartMessageId(MessageId.Earliest)
+ .Topic(topicName)
+ .Create();
+
+ for (var i = 0; i < numberOfMessages; i++)
+ {
+ await producer.Send(content);
+ }
+
+ //Act
+ var messageIds = new List<MessageId>();
+ await foreach (var message in reader.Messages())
+ {
+ messageIds.Add(message.MessageId);
+
+ if (messageIds.Count != numberOfMessages)
+ continue;
+
+ break;
+ }
+
+ //Assert
+ var foundNonNegativeOne = false;
+ foreach (var messageId in messageIds)
+ {
+ if (!messageId.Partition.Equals(-1))
+ foundNonNegativeOne = true;
+ }
+
+ foundNonNegativeOne.Should().Be(true);
+ }
+
+ [Fact]
+ public async Task
GetLastMessageIds_GivenTopicWithThreePartitions_ShouldHaveThreePartitions()
+ {
+ //Arrange
+ const int partitions = 3;
+ const int numberOfMessages = 6;
+ var topicName = $"reader_get_last_message_ids_should_have_3_topics";
+
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}",
partitions);
+
+ await using var client = CreateClient();
+
+ await using var producer = client.NewProducer(Schema.String)
+ .Topic(topicName)
+ .Create();
+
+ await using var reader = client.NewReader(Schema.String)
+ .StartMessageId(MessageId.Earliest)
+ .Topic(topicName)
+ .Create();
+
+ List<MessageId> expected = new List<MessageId>();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
