JooHyukKim commented on PR #20808: URL: https://github.com/apache/pulsar/pull/20808#issuecomment-1674851982
> It seems the CI just failed on the related logics:... My apologies, I have mistaken 🥲. `Deque` and `Stack` classes/interfaces have different semantics for the `push()` / `pop()` / `peek()` operations. | Operation | `Stack` Description | `ArrayDeque` Description | |-----------|---------------------|-------------------------------------| | `push(E e)` | Pushes an item onto the **top(tail)** of this stack. | Inserts the element at the **front(head)** of this deque. | | `pop()` | Removes the object at the **top(tail)** of this stack. | Removes and returns the **first(head)** element of this deque. | | `peek()` | Looks at the object at the **top(tail)** of this stack without removing it. | Retrieves, but does not remove, the **first(head)** element of this deque, or returns null if this deque is empty. ... so modified such operations on `StatsOutputStream` class and added a test. ### Related JDK references - [Stack](https://docs.oracle.com/javase/8/docs/api/java/util/Stack.html) - [Deque](https://docs.oracle.com/javase%2F7%2Fdocs%2Fapi%2F%2F/java/util/Deque.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
