heesung-sn commented on code in PR #20948:
URL: https://github.com/apache/pulsar/pull/20948#discussion_r1291924646
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/MessageDeduplication.java:
##########
@@ -55,6 +55,8 @@ public class MessageDeduplication {
private final ManagedLedger managedLedger;
private ManagedCursor managedCursor;
+ private final ConcurrentOpenHashMap<String, Integer> chunkMessageOngoing;
Review Comment:
What if the chunk msg persist fails on bk after `isDuplicate`? Don't we need
something similar to `highestSequencedPersisted`
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/MessageDeduplication.java:
##########
@@ -55,6 +55,8 @@ public class MessageDeduplication {
private final ManagedLedger managedLedger;
private ManagedCursor managedCursor;
+ private final ConcurrentOpenHashMap<String, Integer> chunkMessageOngoing;
Review Comment:
What if the chunk msg persist fails on bk after `isDuplicate`? Don't we need
something similar to `highestSequencedPersisted`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
