heesung-sn commented on code in PR #20948:
URL: https://github.com/apache/pulsar/pull/20948#discussion_r1292081424
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingSharedTest.java:
##########
@@ -211,6 +213,49 @@ private static String createChunkedMessage(int numChunks) {
return Schema.STRING.decode(payload);
}
+ @Test
Review Comment:
Also,
if feasible, please add other edge case tests.
- broker restarts
- msg persists on bk fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
