flowchartsman commented on PR #1076: URL: https://github.com/apache/pulsar-client-go/pull/1076#issuecomment-1676419416
Some other benefits: - no need for scripts in the happy pathway; the container is automatically created if needed and torn down after testing is complete - code doesn't need to be copied into the container and built for every change, and with a little modification, the container could be made to persist by disabling the reaper container through the use of an environment variable or even a `go run` style container invocation allowing fast iteration on a single test or feature. - the integration container and associated helper functions could be moved into another package, or even another module entirely, which would allow projects based on `pulsar-client-go` to use the same testing infrastructure. In particular, I'm thinking about #819, which would split `pusar-perf` into its own repo. Even though this particular code path does not do IT, it potentially could do so by using the shared IT container code from the main repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
