flowchartsman commented on PR #1076:
URL:
https://github.com/apache/pulsar-client-go/pull/1076#issuecomment-1678435185
Pending the changes in #1077, this PR might end up getting reworked such
that the following code in `helper_for_test.go`
```go
func serviceURL() string {
return integration.URL("pulsar", "6650")
}
func serviceURLTLS() string {
return integration.URL("pulsar+ssl", "6651")
}
func webServiceURL() string {
return integration.URL("http", "8080")
}
func webServiceURLTLS() string {
return integration.URL("https", "8443")
}
```
Becomes
```go
AdminClient() *pulsaradmin.Client {
return pulsaradmin.NewClient(pulsaradmin.ClientConfig{
WebServiceURL: integration.URL("https", "8443"),
BKWebServiceURL: integration.URL("pulsar", "6650"),
//etc
})
}
AdminClientTLS() *pulsaradmin.Client {
return pulsaradmin.NewClient(pulsaradmin.ClientConfig{
WebServiceURL: integration.URL("http", "8080"),
BKWebServiceURL: integration.URL("pulsar+ssl", "6651"),
//etc
})
}
```
Which would then create the integration container only when one of the
helper admin clients is used, while simultaneously dogfooding
`pulsar/pulsaradmin` and increasing coverage. Which would be pretty darn slick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
