entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1295645285
########## tests/DotPulsar.Tests/ReaderTests.cs: ########## @@ -0,0 +1,229 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace DotPulsar.Tests; + +using DotPulsar.Abstractions; +using DotPulsar.Extensions; +using FluentAssertions; +using System; +using System.Collections.Generic; +using System.Threading; +using System.Threading.Tasks; +using Xunit; +using Xunit.Abstractions; + +[Collection("Integration"), Trait("Category", "Integration")] +public class ReaderTests Review Comment: > In the ProducerTests, we should test that the producer is distributing the messages when sending to a partitioned topic. As such we only need to check that all messages are received in the ReaderTests and ConsumerTests. We talked in person about this. > should we test GetLastMessageIds on a non-partitioned topic? Yes we should test both the methods GetLastMessageIds and GetLastMessageId on the reader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
