heesung-sn commented on code in PR #21091:
URL: https://github.com/apache/pulsar/pull/21091#discussion_r1311821809
##########
pulsar-broker/src/main/java/org/apache/pulsar/compaction/StrategicTwoPhaseCompactor.java:
##########
@@ -418,10 +418,9 @@ private <T> void phaseTwoLoop(String topic,
Iterator<Message<T>> reader,
.whenComplete((res, exception2) -> {
if (exception2 != null) {
promise.completeExceptionally(exception2);
- return;
}
+ phaseTwoLoop(topic, reader, lh,
outstanding, promise);
});
- phaseTwoLoop(topic, reader, lh, outstanding, promise);
Review Comment:
> Probably we should use the raw reader to do this, and we have to compact
each batch into different entries.
We could do, but we need to get values from the RawReader to apply the
compaction strategy. We are using the reader interface to reuse the
value-parsing logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
