heesung-sn commented on code in PR #21091:
URL: https://github.com/apache/pulsar/pull/21091#discussion_r1312452272


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -300,6 +301,9 @@ public synchronized void start() throws 
PulsarServerException {
 
             producer = pulsar.getClient().newProducer(schema)
                     .enableBatching(true)
+                    // Make sure input batch size =< compacted output batch,
+                    // Otherwise, the compactor will split the batch to 
multiple batches.

Review Comment:
   nit: Please remove or update this comment, too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to