tisonkun commented on code in PR #21334:
URL: https://github.com/apache/pulsar/pull/21334#discussion_r1350462143
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java:
##########
@@ -57,7 +58,11 @@ public void testReplicatorProducerStatInTopic() throws
Exception {
final byte[] msgValue = "test".getBytes();
admin1.topics().createNonPartitionedTopic(topicName);
- admin2.topics().createNonPartitionedTopic(topicName);
+ try {
+ admin2.topics().createNonPartitionedTopic(topicName);
+ } catch (PulsarAdminException.ConflictException e) {
+ // Ignore
+ }
Review Comment:
Why do we need to create the same topic twice in the first place? I'm afraid
this monkey patch break the manner we want to verify, but it's more likely we
don't even need to create the topic and the subscription twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
