lhotari commented on code in PR #21334:
URL: https://github.com/apache/pulsar/pull/21334#discussion_r1350516233
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java:
##########
@@ -57,7 +58,11 @@ public void testReplicatorProducerStatInTopic() throws
Exception {
final byte[] msgValue = "test".getBytes();
admin1.topics().createNonPartitionedTopic(topicName);
- admin2.topics().createNonPartitionedTopic(topicName);
+ try {
+ admin2.topics().createNonPartitionedTopic(topicName);
+ } catch (PulsarAdminException.ConflictException e) {
+ // Ignore
+ }
Review Comment:
@tisonkun You are right that test code could be improved. I happened to
focus on addressing the flakiness without changing the test logic. I'll remove
the creation of topics and subscriptions completely since it's not needed in
the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
