poorbarcode commented on code in PR #21274:
URL: https://github.com/apache/pulsar/pull/21274#discussion_r1366845862
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -945,12 +954,33 @@ public void completeHandleFuture() {
}
public void exceptionHandleFuture(Throwable t) {
+ if(isRetryableException(t)) {
+ long retryTime = backoff.next();
+ log.warn("[{}][{}] Failed to init transaction pending ack handler.
It will be retried in {} Ms",
+ persistentSubscription.getTopic().getName(), subName,
retryTime, t);
+ transactionOpTimer.newTimeout((timeout) -> init(), retryTime,
TimeUnit.MILLISECONDS);
+ return;
+ }
+ log.error("PendingAckHandleImpl init fail! TopicName : {}, SubName:
{}", topicName, subName, t);
Review Comment:
If the error is not retriable, the Pending Ack Handler will go to a wrong
value. Every request that touches this Pending Ack Handler will get an error,
right?
If yes, what error will the users get? Can we clearly define this error to
make users understand what happened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
