codelipenghui commented on code in PR #21274:
URL: https://github.com/apache/pulsar/pull/21274#discussion_r1381920831
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -945,12 +955,35 @@ public void completeHandleFuture() {
}
public void exceptionHandleFuture(Throwable t) {
+ if(isRetryableException(t)) {
+ long retryTime = backoff.next();
+ log.warn("[{}][{}] Failed to init transaction pending ack handler.
It will be retried in {} Ms",
+ persistentSubscription.getTopic().getName(), subName,
retryTime, t);
+ transactionOpTimer.newTimeout((timeout) -> init(), retryTime,
TimeUnit.MILLISECONDS);
+ return;
+ }
+ log.error("PendingAckHandleImpl init fail! TopicName : {}, SubName:
{}", topicName, subName, t);
+ handleCacheRequest();
+ changeToErrorState();
+ this.pendingAckStoreFuture.completeExceptionally(new
TransactionPendingAckException
+
.TransactionPendingAckStoreInitException(String.format("PendingAckHandleImpl
init fail! TopicName : "
Review Comment:
Sorry, I mean you have created a specific exception
"TransactionPendingAckStoreInitException", it should provide a specific error
message. Because you will not have an error message like "Transaction pending
ack close failed".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
