BewareMyPower commented on code in PR #336:
URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376964472
##########
lib/ClientConfiguration.cc:
##########
@@ -40,6 +40,13 @@ ClientConfiguration&
ClientConfiguration::setMemoryLimit(uint64_t memoryLimitByt
uint64_t ClientConfiguration::getMemoryLimit() const { return
impl_->memoryLimit; }
+ClientConfiguration& ClientConfiguration::setConnectionsPerBroker(int
connectionsPerBroker) {
+ impl_->connectionsPerBroker = connectionsPerBroker;
Review Comment:
Should we add an invalidation here?
```c++
if (connectionsPerBroker <= 0) {
throw std::invalid_argument("connectionsPerBroker should be greater
than 0");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
