BewareMyPower commented on code in PR #336:
URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376992566
##########
lib/ConnectionPool.cc:
##########
@@ -107,7 +108,7 @@ Future<Result, ClientConnectionWeakPtr>
ConnectionPool::getConnectionAsync(
LOG_INFO("Created connection for " << logicalAddress);
Review Comment:
Maybe we can print `key` instead of `logicalAddress` now. Otherwise users
might not know which specific connection is created for `logicalAddress`.
```c++
LOG_INFO("Created connection for " << key);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
