BewareMyPower commented on code in PR #21268:
URL: https://github.com/apache/pulsar/pull/21268#discussion_r1381274841
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java:
##########
@@ -959,13 +959,14 @@ public static ByteBuf newLookupErrorResponse(ServerError
error, String errorMsg,
}
public static ByteBuf newMultiTransactionMessageAck(long consumerId, TxnID
txnID,
- List<Triple<Long, Long, ConcurrentBitSetRecyclable>> entries) {
+ List<Triple<Long, Long, ConcurrentBitSetRecyclable>> entries, long
requestID) {
BaseCommand cmd = newMultiMessageAckCommon(entries);
cmd.getAck()
.setConsumerId(consumerId)
.setAckType(AckType.Individual)
.setTxnidLeastBits(txnID.getLeastSigBits())
- .setTxnidMostBits(txnID.getMostSigBits());
+ .setTxnidMostBits(txnID.getMostSigBits())
+ .setRequestId(requestID);
return serializeWithSize(cmd);
Review Comment:
I think we don't need this change now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
