liangyepianzhou commented on code in PR #21268:
URL: https://github.com/apache/pulsar/pull/21268#discussion_r1382869275
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2800,12 +2806,34 @@ private CompletableFuture<Void>
doTransactionAcknowledgeForResponse(MessageId me
} else {
bitSetRecyclable.clear(messageIdAdv.getBatchIndex());
}
- cmd = Commands.newAck(consumerId, ledgerId, entryId,
bitSetRecyclable, ackType, validationError, properties,
- txnID.getLeastSigBits(), txnID.getMostSigBits(),
requestId, messageIdAdv.getBatchSize());
+ cmdList.add(Commands.newAck(consumerId, ledgerId, entryId,
bitSetRecyclable, ackType, validationError, properties,
+ txnID.getLeastSigBits(), txnID.getMostSigBits(),
requestId, messageIdAdv.getBatchSize()));
Review Comment:
This is indeed an issue, but it is unrelated to this PR. This PR does not
alter the behavioral logic of cumulative ack and batch messages. It simply
consolidates the multiple commands of the chunk message into a list. This
change does not cause any additional system calls to be triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
