dragosvictor commented on code in PR #21682:
URL: https://github.com/apache/pulsar/pull/21682#discussion_r1424853996
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1842,6 +1843,15 @@ protected void handleAck(CommandAck ack) {
if (consumerFuture != null && consumerFuture.isDone() &&
!consumerFuture.isCompletedExceptionally()) {
Consumer consumer = consumerFuture.getNow(null);
+ Subscription subscription = consumer.getSubscription();
+ if (subscription.getTopic().isTransferring()) {
Review Comment:
Not specifically, but the modified test covers ack behavior:
https://github.com/apache/pulsar/pull/21682/files#diff-744119c61c9f6a1b786c3966acd1e0f63748985cf68a6a1a15418c8d9900a9a8R543-R547.
The test does not succeed unless all messages sent during the transfer surface
out on the consumers. Since there are 200 messages involved, at least one of
them likely has the acknowledgement initially ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
