dragosvictor commented on code in PR #21682:
URL: https://github.com/apache/pulsar/pull/21682#discussion_r1425761138
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Subscription.java:
##########
@@ -64,13 +65,13 @@ default long getNumberOfEntriesDelayed() {
List<Consumer> getConsumers();
- CompletableFuture<Void> close();
Review Comment:
@gaoran10 What do you think? I'd opt for keeping the interface lean unless
otherwise necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
