coderzc commented on code in PR #21423:
URL: https://github.com/apache/pulsar/pull/21423#discussion_r1431169257
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -995,6 +1023,13 @@ public void addUnAckedMessages(int numberOfMessages) {
topic.getBrokerService().addUnAckedMessages(this, numberOfMessages);
}
+ @Override
+ public void afterAckMessages(Object position, Throwable error, Object ctx)
{
+ if (!cursor.isMetadataTooLargeToPersist()) {
Review Comment:
Use `shouldPauseOnAckStatePersist` directly?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -354,6 +369,19 @@ public synchronized void readMoreEntries() {
}
}
+ private boolean shouldPauseOnAckStatePersist(ReadType readType) {
+ if (readType != ReadType.Normal) {
+ return false;
+ }
Review Comment:
Why don't you pause replay read? acknowledge replay message will also
increase size of individualDeletedMessages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
