poorbarcode commented on code in PR #21423:
URL: https://github.com/apache/pulsar/pull/21423#discussion_r1432348749
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -354,6 +369,19 @@ public synchronized void readMoreEntries() {
}
}
+ private boolean shouldPauseOnAckStatePersist(ReadType readType) {
+ if (readType != ReadType.Normal) {
+ return false;
+ }
Review Comment:
> @coderzc Why don't you pause replay read? acknowledge replay message will
also increase size of individualDeletedMessages.
> @codelipenghui I think the reason should be consumers can disconnect from
the topic if we stop dispatching messages to the active consumer. Somehow, the
dispatching will stop forever.
Yes, @codelipenghui said is right.
> could you please add some comments here?
added.
> we should also add test for the consumer disconnection to make sure the
remaining active consumers can ultimately consume all messages
Sure, they are `testPauseOnAckStatPersistNotAffectReplayRead` and
`testMultiConsumersPauseOnAckStatPersistNotAffectReplayRead`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
