BewareMyPower commented on code in PR #21745:
URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436982457
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1220,7 +1221,7 @@ private void
asyncDeleteCursorWithClearDelayedMessage(String subscriptionName,
if (ex != null) {
unsubscribeFuture.completeExceptionally(ex);
} else {
Review Comment:
> Should we delete the cursor after the in-progress compaction task is
finished?
I agree. We should first stop the compaction, then delete the cursors.
And it's better to add a test for topic force deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
