coderzc commented on code in PR #21745:
URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436889749
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1220,7 +1221,7 @@ private void
asyncDeleteCursorWithClearDelayedMessage(String subscriptionName,
if (ex != null) {
unsubscribeFuture.completeExceptionally(ex);
} else {
Review Comment:
@poorbarcode @codelipenghui
> Should we delete the cursor after the in-progress compaction task is
finished?
If there is a compaction task in progress and RawRead is already connected
to the topic, then the topic will not be deleted.
> it looks like the RawReader will create the topic again if the topic
auto-creation is enabled on the broker-side. Will it cause a topic deletion
failure if there is a running compactor
I changed the `createTopicIfDoesNotExist` of RawReader to false and added a
check if the topic is closing or deleting before triggering compaction. So, the
case of recreating the topic should not happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
