shibd commented on code in PR #357:
URL:
https://github.com/apache/pulsar-client-node/pull/357#discussion_r1444114662
##########
src/ConsumerConfig.h:
##########
@@ -21,14 +21,17 @@
#define CONSUMER_CONFIG_H
#include <pulsar/c/consumer_configuration.h>
+#include "ThreadSafeDeferred.h"
#include "MessageListener.h"
#define MIN_ACK_TIMEOUT_MILLIS 10000
class ConsumerConfig {
public:
- ConsumerConfig(const Napi::Object &consumerConfig, pulsar_message_listener
messageListener);
+ ConsumerConfig();
~ConsumerConfig();
+ void InitConfig(const std::shared_ptr<ThreadSafeDeferred> deferred, const
Napi::Object &consumerConfig,
Review Comment:
Got it. Thanks for your reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
