shibd commented on code in PR #357:
URL:
https://github.com/apache/pulsar-client-node/pull/357#discussion_r1444120780
##########
src/ConsumerConfig.cc:
##########
@@ -265,6 +291,39 @@ ConsumerConfig::ConsumerConfig(const Napi::Object
&consumerConfig, pulsar_messag
}
pulsar_consumer_configuration_set_dlq_policy(this->cConsumerConfig.get(),
&dlq_policy);
}
+
+ if (consumerConfig.Has(CFG_BATCH_RECEIVE_POLICY) &&
+ consumerConfig.Get(CFG_BATCH_RECEIVE_POLICY).IsObject()) {
+ Napi::Object propObj =
consumerConfig.Get(CFG_BATCH_RECEIVE_POLICY).ToObject();
+ int maxNumMessages = -1;
+ if (propObj.Has(CFG_BATCH_RECEIVE_POLICY_MAX_NUM_MESSAGES) &&
Review Comment:
This logic has been added on the CPP client:
https://github.com/apache/pulsar-client-cpp/blob/main/lib/ConsumerImplBase.cc#L38-L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
