dragosvictor commented on code in PR #21866:
URL: https://github.com/apache/pulsar/pull/21866#discussion_r1446750374
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -804,7 +804,9 @@ private void handleReleaseEvent(String serviceUnit,
ServiceUnitStateData data) {
if (isTransferCommand(data)) {
next = new ServiceUnitStateData(
Assigning, data.dstBroker(), data.sourceBroker(),
getNextVersionId(data));
- unloadFuture = closeServiceUnit(serviceUnit, false);
+ // If the optimized bundle unload is disabled, disconnect the
clients at time of RELEASE.
+ var disconnectClients =
!pulsar.getConfig().isLoadBalancerOptimizeBundleUnload();
Review Comment:
@heesung-sn What would be the consequence of changing this flag in the
middle of an operation, between the RELEASE and OWN states? Perhaps I should
make it non-dynamic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
