heesung-sn commented on code in PR #21866:
URL: https://github.com/apache/pulsar/pull/21866#discussion_r1446861124
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -779,7 +779,9 @@ private void handleOwnEvent(String serviceUnit,
ServiceUnitStateData data) {
lastOwnEventHandledAt = System.currentTimeMillis();
stateChangeListeners.notify(serviceUnit, data, null);
log(null, serviceUnit, data, null);
- } else if ((data.force() || isTransferCommand(data)) &&
isTargetBroker(data.sourceBroker())) {
+ } else if (isTargetBroker(data.sourceBroker())
+ && (data.force() // orphan cleanup
+ || (isTransferCommand(data) &&
pulsar.getConfig().isLoadBalancerMultiPhaseBundleUnload()))) { // txfer
stateChangeListeners.notifyOnCompletion(
closeServiceUnit(serviceUnit, true), serviceUnit,
data)
Review Comment:
I am sorry. I realized We still need to log the transfer case even when this
flag is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
