dragosvictor commented on code in PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#discussion_r1449905221
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##########
@@ -317,6 +321,78 @@ public Object[][] indexPatternTestData() {
};
}
+ @DataProvider(name = "closeWithoutWaitingClientDisconnectInFirstBatch")
+ public Object[][] closeWithoutWaitingClientDisconnectInFirstBatch() {
+ return new Object[][]{
+ new Object[] {true},
+ new Object[] {false},
+ };
+ }
Review Comment:
Nit: this test block sits between the previous `DataProvider`
(`topicAndMetricsLevel`) and the corresponding test
(`testDelayedDeliveryTrackerMemoryUsageMetric`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
