lhotari commented on code in PR #448:
URL: https://github.com/apache/pulsar-helm-chart/pull/448#discussion_r1472871159
##########
charts/pulsar/values.yaml:
##########
@@ -1326,11 +1327,14 @@ pulsar_manager:
hostname: ""
path: "/"
- ## If set use existing secret with specified name to set pulsar admin
credentials.
- existingSecretName:
+ ## On first install, the helm chart tries to reuse an existing secret with
matching name by default
+ ## if this should fail it uses the given username and password to create a
new secret
+ ## if either are missing the default value of "pulsar" is used for the
username or a random password is generated
+ ## And decode any key by using:
+ ## kubectl get secret -l component=pulsar-manager
-o=jsonpath="{.items[0].data.PASSWORD}" | base64 --decode
admin:
- user: pulsar
- password: pulsar
+ username: "pulsar"
+ password: "" # leave empty for random password
Review Comment:
Linting failed on this line: `1337:18 [comments] too few spaces before
comment`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
