Mortom123 commented on PR #448: URL: https://github.com/apache/pulsar-helm-chart/pull/448#issuecomment-1919611961
@lhotari I added both credentials as well as CI tests. But the tests have some problems: 1. [Here](https://github.com/Mortom123/pulsar-helm-chart/actions/runs/7729592231/job/21073185950) the pulsar manager is not ready to accept connections before being hit by the `curl`. [I tried to fix this](https://github.com/apache/pulsar-helm-chart/pull/448/commits/8d51e36e80362916d3ce91fa8ee38b1891d9503e) by always waiting for jobs to complete in the pipeline. I don't know why we don't wait when installing anyway? Maybe you have some explanation? 2. This also [failed](https://github.com/Mortom123/pulsar-helm-chart/actions/runs/7730062235/job/21074647869), because it takes some time for the job to be triggered (both manager + broker need to be fully ready). There are now a couple of ways to fix this: 1. Increase wait timeout in $install_args 2. Revert the commit touching $install args and put an `until` loop before hitting the manager in a similar fashion as [here](https://github.com/apache/pulsar-helm-chart/pull/448/files#diff-74de41a8d85b68c1af8abd4b3d74957919cb9db860425acf0de6a87460719162R53). I would prefer to wait for all jobs to complete during install. But what do you or @frankjkelly think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
