hanmz commented on code in PR #21906:
URL: https://github.com/apache/pulsar/pull/21906#discussion_r1477196573
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java:
##########
@@ -154,8 +154,7 @@ public Multimap<String, String>
findBundlesForUnloading(final LoadData loadData,
}
String bundle = e.getLeft();
double bundleMsgRate = e.getRight();
- if (bundleMsgRate <=
(msgRateRequiredFromUnloadedBundles.getValue()
- + 1000/* delta */)) {
Review Comment:
I understand that delta=1000 here does not have much meaning. The initial
design was just to allow the data of one shedding to reach a certain threshold
and to prevent the data flow of one shedding from being too small.
However, later we added the configuration minUnloadMessage and
minUnloadMessageThroughput. These two configurations can completely replace the
role of delta=1000, so the delta here is meaningless.
However, due to the existence of delta=1000, broker load balancing cannot be
achieved in small traffic scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
